Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging Go Driver branch into main #79

Merged
merged 76 commits into from
Jan 16, 2025
Merged

Merging Go Driver branch into main #79

merged 76 commits into from
Jan 16, 2025

Conversation

zjrgov
Copy link
Contributor

@zjrgov zjrgov commented Jan 16, 2025

Not really necessary to keep them separate anymore.

zjrgov added 30 commits January 16, 2025 15:52
@zjrgov
adding basic go skele
ce03c37
@zjrgov
adding simple makefile
2a2abc6
@zjrgov
feat: parse VCAP & use to connect with cloud.gov
b5895ef 
Also added a silly little test that does nothind
@zjrgov
feat: parse creds from VCAP_SERVICES env var
c7fc20b
@zjrgov
refactor: simplify GetCredentials test
8c407b5
@zjrgov
refactor: better error handling
ab70e74
@zjrgov
refactor: slightly better read flow for getting config
50eaa2a
@zjrgov
chore: add standard ignores for Go
32f98a4
@zjrgov
chore: move go code into its proper place
bfea6b8
@zjrgov
refactor: simplify error check for json.Unmarshal
d6be17b
@zjrgov
test: more robust testing of GetCredentials
e749436 
- validate failure with bad data
- uses go-cmp for struct comparison
- uses table structure to make additional cases easier to add
@zjrgov
test: skip Test_main because it's just meant for experiments right now
49d3151
@zjrgov
refactor: decouple GetCfClient from GetCredentials
5fb7f30
@zjrgov
feat: allow explicit config of CF user/pass w/ envvars
67d8249
@zjrgov
fix: move & comment out the CfClient test that snuck in
18f9f3f
@zjrgov
refactor: Credentials -> CfCredentials for specificity
b76d62f
@zjrgov
refactor: move Makefile & go gitignore
13151dd
@zjrgov
feat: add godotenv, load in main
d59e1dd
@zjrgov
refactor: wrapping cfclient poc
4c60148
@zjrgov
refactor: move relevant cloud.gov logic w/ adapter for cf-goclient
0aac409
@zjrgov
refactor: move creds code into its own file
450af89
@zjrgov
chore: add launch.json for debug config
e5a7e55
@zjrgov
refactor: colocate creds tests and fix names
f74cfd5
@zjrgov
fix: add json tag for CGSrvAct.Creds, make isEmpty an OR
7cc5d7c
@zjrgov
chore: rearrange Test_getCreds fields for better data alignment
6e47235
@zjrgov
test: add tests & test stubs for CG
59bb468
@zjrgov
test: adding tests for rest of the CG stubs
1b705bc
@zjrgov
fix: issue with nil creds
a110cb7
@zjrgov
chore: delete commented out stub test from main_test.go
b2ae777
@zjrgov
refactor: Adapter -> CloudI, more descriptive and fun
97f35aa
zjrgov added 19 commits January 16, 2025 15:54
@zjrgov
Revert "chore: add a bug to validate test failure"
7f8ba86 
This reverts commit 9cc8c15.
@zjrgov
feat: upgrade setup-go to v5
ec98588
@zjrgov
feat: get go version for action from go.mod
287cbb4
@zjrgov
chore: not necessary to pin a patch version for go
e717240
@zjrgov
feat: add integration test for go driver's CG
6e69483
@zjrgov
fix: have to name package pkgname_test
c31c6f2
@zjrgov
fix: forgot t.Error/t.Fail doesn't exit
874c440
@zjrgov
docs: note about integration test in readme, helpful error message
ac02ee5
@zjrgov
fix: prevent caching integration test which defeats the purpose
4b6dc62
@zjrgov
feat: structure as CLI tool, with drive subcmd for each stage
f6e41b1 
Also includes some long command descriptions that are mostly
lifted from GitLabs Custom executor documentation.
@zjrgov
chore: should have run tidy
aea1f0a
@zjrgov
chore: trigger pr workflow
e35c5d9
@zjrgov
refactor: rename cf-driver to cfd
fa02c73
@zjrgov
fix: forgot to update path in GH action
899d25a
@zjrgov
feat: add types & functions to parse env config
4e789fb
@zjrgov
refactor: should have used pointers
f12009b
@zjrgov
refactor: use more descriptive variable names
736d2f0
@zjrgov
chore: delete unused parse for CF_DOCKER_PASSWORD
c2abd96
@zjrgov
chore: delete unused parse for CF_DOCKER_PASSWORD, Pt II
2c65099 
This is what I get for my hubris
@zjrgov zjrgov requested a review from a team January 16, 2025 20:58
@zjrgov zjrgov self-assigned this Jan 16, 2025
rahearn
rahearn previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@zjrgov
Copy link
Contributor Author

zjrgov commented Jan 16, 2025

@rahearn I was just realizing runner/ is runner-manager/ now. You didn't mean to keep them separate, right?

@rahearn
Copy link
Contributor

rahearn commented Jan 16, 2025

@rahearn I was just realizing runner/ is runner-manager/ now. You didn't mean to keep them separate, right?

good catch, no, I think having runner-manager/cf-driver be the bash version and runner-manager/cfd be the go version will be the cleanest side-by-side we can do

@zjrgov zjrgov merged commit b4b79b2 into main Jan 16, 2025
3 checks passed
@zjrgov zjrgov deleted the go/main branch January 16, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahearn rahearn rahearn approved these changes

Assignees

@zjrgov zjrgov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zjrgov @rahearn