Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refit of already-longoptified modules to incorporate multi-directives #8046

Merged
merged 8 commits into from
Nov 30, 2023

Conversation

rbdavis
Copy link
Contributor

@rbdavis rbdavis commented Nov 18, 2023

Description of proposed changes

This PR contains new long-option strings for 4 already-longoptified modules (blockmean, blockmode, fitcircle and gmtregress) which use the new multi-directive feature that was recently added. Please review only the newly added multi-directive long-option strings (i.e., only the green code lines) in these modules, and not the pre-existing long-option strings which have already been reviewed and approved in previous PRs.

Also, a modified gmtconvert_inc.h file is included here which basically only has some changed code indents from what was already reviewed and approved about a week ago. That earlier PR was not merged until earlier today because it also had multi-directive issues which are now resolved. I'm not sure why the code diff below is showing another old version of gmtconvert_inc.h (undoubtedly something stupid that I did), but the new code (green) is in fact correct and is essentially unchanged from what was reviewed and approved in that earlier gmtconvert PR.

This PR brings all of the already-longoptified modules up-to-date with respect to the new multi-directive stuff.

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@rbdavis rbdavis requested a review from a team November 18, 2023 02:11
@rbdavis
Copy link
Contributor Author

rbdavis commented Nov 18, 2023

OK, I think I have fixed whatever weird was going on with the gmtconvert_inc.h file diff. It now seems to be completely removed from this PR, which I don't quite understand but I guess is OK. If it turns out there is a problem I will fix later in a separate PR.

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since "my" module I chose a different set of names for -W.

@rbdavis rbdavis merged commit 5bd2cd3 into master Nov 30, 2023
6 checks passed
@rbdavis rbdavis deleted the longopts-mdrefit branch November 30, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants