Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add longoptions support for gmtvector. #8069

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Add longoptions support for gmtvector. #8069

merged 2 commits into from
Nov 30, 2023

Conversation

rbdavis
Copy link
Contributor

@rbdavis rbdavis commented Nov 23, 2023

Description of proposed changes

Python differences:

No python module.

Julia differences:

Replaced -A single_vec with primary_vector. The man page refers
to a single vector in its description of both the -A and -S options
('single primary' in the former case, and 'single secondary' in the
latter), hence it's misleading to refer only to -A as 'single_vec'.

Fixes #8068

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@rbdavis rbdavis requested a review from a team November 23, 2023 02:38
Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@PaulWessel PaulWessel requested a review from a team November 23, 2023 10:12
@rbdavis rbdavis merged commit 2f3d192 into master Nov 30, 2023
6 checks passed
@rbdavis rbdavis deleted the longopts-gmtvector branch November 30, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add longoptions support for gmtvector.
3 participants