Fix lack of xyz->xy conversion for graticules in grdview -T #8072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use gmt_graticule_path to uild polygons for each grid node but in grdview we need to project them to 3-D coordinates (x,y,z to x', y')
|
I went back to grdview 6.0 code and whatever that was it had the same bug, so nothing recent other than a new function that had the same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8036 for background. We use gmt_graticule_path to uild polygons for each grid node but in grdview we need to project them to 3-D coordinates (x,y,z to x', y')
Now,
gmt grdview @earth_relief_10m -JB-90/21/19/23/10c -R-92/-87/19/23 -p-30/40 -Cglobe -B -BWSen -T -png mapyields
gmt grdview @earth_relief_10m -JB-90/21/19/23/10c -R-92/-87/19/23 -p-30/40 -Cglobe -B -BWSen -Qc -png mapstill fails (below) but that is a separate branch in grdview that needs another fix by another PR.