Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen -Elines documentation for grdtrack and grdinterpolate #8108

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

PaulWessel
Copy link
Member

This PR deals with two separate improvements:

  1. The grdtrack and grdinterpolate modules both use the very rich -E option for creating profiles on the fly. The repetitive documentation for the two had some issues and missing modifiers, so this PR adds a shared explain_interpolant.rst_ file.
  2. Also, the parsing and synopsis and usage of -F for the interpolant differed between the sample1d and grdinterpolate modules so I have introduced some library functions that both can call to avoid duplicate and missing directives in the code. Likewise, for the documentation I added a shared explain_interpolant.rst.

Unfortunately, the docs for -E is not showing up in the HTML and I cannot see any difference between the include stuff for -E and -F, so I will need help to find probably an obvious issue, hence WIP.

These two functions both use the very rich -E option for creating profiles on the fly.  The repetitive documentation for the two ahd some issues and missing modifiers, so this PR addes an explain_interpolant.rst_ file they can share.  Also, the parsing of -F for the interpolant different between the two modules so I have introduced some function that both can call to avoid duplicate and errors in the code.  Likewise, for teh documentation I added explain_interpolant.rst
@PaulWessel PaulWessel added documentation Improve documentation maintenance Boring but important stuff for the core devs labels Nov 29, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Nov 29, 2023
@PaulWessel PaulWessel self-assigned this Nov 29, 2023
@PaulWessel PaulWessel requested a review from a team November 29, 2023 15:58
@PaulWessel PaulWessel merged commit 1200849 into master Nov 29, 2023
@PaulWessel PaulWessel deleted the lines-opt-interpolant-opt branch November 29, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improve documentation maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants