GSLUX-608 Activate UglifyPlugin #3143

tkohr · 2024-05-15T15:10:58Z

The goal of this PR is to allow activating the UglifyJsPlugin.

To do so, it:

uses the legacy build from GSLUX-608: Generate uglifiable lib build luxembourg-geoportail#103
raises the memory limit for webpack
gets rid of minification issues in Themes.js detected via strictDi: true

To-dos:

remove strictDi: true => kept it to catch minification issues on dev in the future
remove exclusions in UglifyJsPlugin (to be tested)
revert .js/.mjs modifications and handle according version for dev and prod => kept .js extension (since prod is no mjs anymore), coping both dev and prod sources to a lux.dist.js file after lib build
cleanup and test

use `strictDi: true` for now to reproduce in dev mode

both exclusions do not seem to be working and may be removed

and remove exclusions from UglifyJsPlugin

AlitaBernachot

Working great! Thanks for the work

tkohr added 7 commits May 14, 2024 21:02

try using babel build

b3f613d

try using rollup build

4561748

fix(themes): get rid of minify error

e342c4a

use `strictDi: true` for now to reproduce in dev mode

try using lib build without mapbox-gl

ac2d869

exclude mapbox-gl from uglify

1377555

both exclusions do not seem to be working and may be removed

point to legacy build integrated in vite config

80624e0

and remove exclusions from UglifyJsPlugin

point to legacy build generated via babel cli

b43aa1c

tkohr marked this pull request as ready for review May 22, 2024 14:29

AlitaBernachot approved these changes May 23, 2024

View reviewed changes

tkohr merged commit 3578912 into integration-vue May 23, 2024

tkohr deleted the uglify-test branch May 23, 2024 08:59

tkohr mentioned this pull request May 23, 2024

GSLUX-608: Use webpack uglify plugin #3079

Closed

Provide feedback