Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-722: Fix embedded mode #3179

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

AlitaBernachot
Copy link
Contributor

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-722

Description

  • Add new functionality to v4: embedded mode (just add param ?embedded=true in url)
  • Force resize map when embedded mode, with a timer for v3 (because of angular component, wait until they have finish rendering header and footer that will disappear, otherwise, there is an unwanted gutter). For v4, no timer needed.

NB. This PR needs Geoportail-Luxembourg/luxembourg-geoportail#125

Copy link
Contributor

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlitaBernachot !

@@ -17,6 +17,8 @@ import olMap from 'ol/Map.js';
import offlineUtils from 'ngeo/offline/utils.js';

function resizeMap(map) {
console.log("resizeMap ---")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed, I guess.

@AlitaBernachot AlitaBernachot force-pushed the GSLUX-722-fix-embedded-mode branch from a11beac to 56d7870 Compare July 31, 2024 08:55
@AlitaBernachot AlitaBernachot merged commit fb12a5f into integration-vue Jul 31, 2024
@AlitaBernachot AlitaBernachot deleted the GSLUX-722-fix-embedded-mode branch July 31, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants