Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-698: FIX init bg config AFTER urls init #109

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

AlitaBernachot
Copy link
Contributor

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-698

Description

Add init bg configs function, this initialization must be made AFTER vectortiles url initialization (this a a patch for v3)

Copy link
Contributor

github-actions bot commented Jun 4, 2024

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-698-fix-mvt-urls-bis/

@AlitaBernachot AlitaBernachot requested review from tkohr and mki-c2c June 4, 2024 07:13
Copy link
Contributor

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AlitaBernachot ! As far as I can see, the change makes sense to me. I was just wondering why the style.json is already recovered from https://vectortiles-staging.geoportail.lu/styles/roadmap/style.json in local dev without this change.

@AlitaBernachot
Copy link
Contributor Author

Thanks, @AlitaBernachot ! As far as I can see, the change makes sense to me. I was just wondering why the style.json is already recovered from https://vectortiles-staging.geoportail.lu/styles/roadmap/style.json in local dev without this change.

My guess is that in dev url intialization happens before bg configuration because there is no minification? whereas in production mode all stores including useStylesStore() (the one that was making the bg configuration before this PR) are launched at once? This is just a supposition, I did not find the reason, already spent too much time on this...

@AlitaBernachot AlitaBernachot merged commit e824930 into main Jun 4, 2024
2 checks passed
@AlitaBernachot AlitaBernachot deleted the GSLUX-698-fix-mvt-urls-bis branch June 4, 2024 08:25
@tkohr
Copy link
Contributor

tkohr commented Jun 4, 2024

Nice I see it fixed it for migration indeed :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants