Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-695: Draw toolbar #110

Merged
merged 5 commits into from
Jun 13, 2024
Merged

GSLUX-695: Draw toolbar #110

merged 5 commits into from
Jun 13, 2024

Conversation

tkohr
Copy link
Contributor

@tkohr tkohr commented Jun 7, 2024

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-695

Description

This PR adds the buttons for the draw toolbar for desktop and mobile. UI only, no functionality yet.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-695-draw-toolbar/

Copy link
Contributor

@mki-c2c mki-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the checkbox 'follow routes' is visible by default, whereas on prod it only appears when the line tool is selected.
But this is probably normal since ther are no logics associated yet.

@tkohr tkohr force-pushed the GSLUX-695-draw-toolbar branch from 565adc4 to 3f93e39 Compare June 13, 2024 08:53
@tkohr
Copy link
Contributor Author

tkohr commented Jun 13, 2024

LGTM, the checkbox 'follow routes' is visible by default, whereas on prod it only appears when the line tool is selected. But this is probably normal since ther are no logics associated yet.

Thanks for the review @mki-c2c ! Good point, I've added a commit to handle the 'follow roads' checkbox and rebased the PR.

@tkohr tkohr merged commit b29b395 into main Jun 13, 2024
2 checks passed
@tkohr tkohr deleted the GSLUX-695-draw-toolbar branch June 13, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants