Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-701: Missing text "No layer selected" when offline #117

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

AlitaBernachot
Copy link
Contributor

@AlitaBernachot AlitaBernachot commented Jul 8, 2024

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-701

Description

  • Add missing text "No layer selected" when user switches to offline mode
  • Update icons and add new scholl theme (after merging main onto integration-vue)

NB. MyMaps is not functional at this time in v4, this fix is should better be tested in v3.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-701-no-layers-mymaps/

@AlitaBernachot AlitaBernachot force-pushed the GSLUX-701-no-layers-mymaps branch from dfcd350 to f519e09 Compare July 11, 2024 14:05
@AlitaBernachot AlitaBernachot changed the title GSLUX-701: Missing text "No layer selected" when my map opened GSLUX-701: Missing text "No layer selected" when offline Jul 11, 2024
Copy link
Contributor

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not retest it since I need to rebuild, but changes look good to me, thanks!

@AlitaBernachot AlitaBernachot merged commit 1dd6ef3 into main Jul 15, 2024
2 checks passed
@AlitaBernachot AlitaBernachot deleted the GSLUX-701-no-layers-mymaps branch July 15, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants