GSLUX-694: Draw panel #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-694-draw-panel/ |
AlitaBernachot
force-pushed
the
GSLUX-694-draw-panel
branch
3 times, most recently
from
ff894d3 to
93b8826
Compare
AlitaBernachot
force-pushed
the
GSLUX-694-draw-panel
branch
from
a2f0fdd to
c8a69ae
Compare
AlitaBernachot
force-pushed
the
GSLUX-694-draw-panel
branch
4 times, most recently
from
4c5f6df to
661b8e6
Compare
AlitaBernachot
force-pushed
the
GSLUX-694-draw-panel
branch
from
661b8e6 to
b5d6645
Compare
mki-c2c
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
This is very nice work.
The dialogs work well, some todos I could see are:
- angle for labels (label style todo)
- opacity
- coupling of number spinboxes and sliders
I suppose these will be part of a new PR.
In some cases, I found the styling to be better than the prod version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-694
Description
New draw panel components.
To be continued in another PR:
Screenshots