Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-756: Display feature info in info panel #171

Merged
merged 45 commits into from
Dec 11, 2024
Merged

Conversation

tkohr
Copy link
Contributor

@tkohr tkohr commented Nov 15, 2024

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-756

Description

The goal of this PR is to set a base for the feature info. It now displays the feature info of the default template.

Remaining to-dos for separate PRs remain:

  • Migrate all other templates and potentially corresponding logic from the QueryController
  • Migrate the modal currently commented in feature-info.vue (originating from info.html)

Permalink with all layers to test default-template.html: http://localhost:5173/theme/main?version=3&lang=fr&X=702429&Y=6396653&zoom=16&rotation=0&features=&layers=655-2842-808-1713-1714-269-302-1813&opacities=1-0-1-1-1-1-1-1&time=--------------&bgLayer=basemap_2015_global

⚠️ DO NOT MERGE UNTIL RELEASE/TAG IS OUT. ⚠️

Base automatically changed from GSLUX-754-info-panel to main November 18, 2024 10:00
@tkohr tkohr force-pushed the GSLUX-756-feature-info branch from c31406e to 2ecf13b Compare November 18, 2024 15:56
Copy link
Contributor

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-756-feature-info/

@tkohr tkohr force-pushed the GSLUX-756-feature-info branch 2 times, most recently from 6d436a1 to 8f304a6 Compare December 3, 2024 10:44
@tkohr tkohr marked this pull request as ready for review December 4, 2024 10:09
@tkohr tkohr force-pushed the GSLUX-756-feature-info branch from 9ededd0 to 6ca91ac Compare December 9, 2024 15:00
@tkohr
Copy link
Contributor Author

tkohr commented Dec 9, 2024

PR is now ready from my side. The last bugs I noted above are solved, as well as:

Tested on github pages, working great, some minor things i have noticed:

* Width when clickin on direct link

=> Fixed now, could potentially still be improved but the absolute positioning (necessary to make y overflow scroll) make this more complicated. Maybe there could be a solution without the absolute in the future.

* maybe improve line height between lines (not between label and values like in prod wich is weird) (1st image github pages, 2nd production)

=> Didn't further change this so far. The larger spacing at the top of the bow actually comes from empty h4 being rendered in angular. I also thought a little more compcact layout wouldn't hurt if there is much content. We can also still make this evolve with the template if we feel the need I think.

* exports button height is not the same as in prod (+ it could be great to add some margin between buttons and the graph, but this is my opinion, i let you decide)

=> Fixed

* export CSV is not working

=> Fixed

Note: rebase was needed to fix from today.

DO NOT MERGE UNTIL RELEASE/TAG IS OUT.

@tkohr tkohr merged commit 19aa9fa into main Dec 11, 2024
2 checks passed
@tkohr tkohr deleted the GSLUX-756-feature-info branch December 11, 2024 08:33
@@ -0,0 +1,88 @@
<script setup lang="ts">
import { defineProps, onUnmounted } from 'vue'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants