-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSLUX-756: Display feature info in info panel #171
Conversation
c31406e
to
2ecf13b
Compare
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-756-feature-info/ |
6d436a1
to
8f304a6
Compare
partially cherry picked from #175
using throttle and more
providing default filename from v3
to not display instruction text during loading (due to content setting and checking mixing up)
to prevent clearing features when panning map. clearing is done later in done() already
9ededd0
to
6ca91ac
Compare
PR is now ready from my side. The last bugs I noted above are solved, as well as:
=> Fixed now, could potentially still be improved but the absolute positioning (necessary to make y overflow scroll) make this more complicated. Maybe there could be a solution without the
=> Didn't further change this so far. The larger spacing at the top of the bow actually comes from empty
=> Fixed
=> Fixed Note: rebase was needed to fix from today. DO NOT MERGE UNTIL RELEASE/TAG IS OUT. |
src/services/state-persistor/state-persistor-featureinfo.service.ts
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,88 @@ | |||
<script setup lang="ts"> | |||
import { defineProps, onUnmounted } from 'vue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, thanks!
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-756
Description
The goal of this PR is to set a base for the feature info. It now displays the feature info of the default template.
Remaining to-dos for separate PRs remain:
QueryController
info.html
)Permalink with all layers to test
default-template.html
: http://localhost:5173/theme/main?version=3&lang=fr&X=702429&Y=6396653&zoom=16&rotation=0&features=&layers=655-2842-808-1713-1714-269-302-1813&opacities=1-0-1-1-1-1-1-1&time=--------------&bgLayer=basemap_2015_global