Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-734: My symbols #173

Merged
merged 10 commits into from
Dec 19, 2024
Merged

GSLUX-734: My symbols #173

merged 10 commits into from
Dec 19, 2024

Conversation

AlitaBernachot
Copy link
Contributor

@AlitaBernachot AlitaBernachot commented Nov 20, 2024

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-734

Description

Display private symbols when user is connected. Allow user to upload new private symbols.

To make it work, you must:

@AlitaBernachot AlitaBernachot changed the base branch from main to GSLUX-686-profil-component November 20, 2024 17:21
Copy link
Contributor

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-734-my-symbols/

@AlitaBernachot AlitaBernachot force-pushed the GSLUX-734-my-symbols branch 3 times, most recently from 8c072b5 to 1983881 Compare November 27, 2024 17:39
@AlitaBernachot AlitaBernachot force-pushed the GSLUX-686-profil-component branch 2 times, most recently from 16d5324 to 94bd918 Compare November 28, 2024 12:37
Base automatically changed from GSLUX-686-profil-component to main November 28, 2024 13:23
@AlitaBernachot AlitaBernachot force-pushed the GSLUX-734-my-symbols branch 3 times, most recently from 7828e9e to 472a2de Compare December 16, 2024 17:58
Copy link
Contributor

@mki-c2c mki-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems like a big piece of work with a lot of refactoring.

Tested it thoroughly with local API.
reload of private icon list works well after upload.

For the DB update, the part concernig mymaps structure should go into an alembic migration script in geoportail_v3, the sample data is fine in luxembourg_dev_db.

Thanks for the refactoring of multiple symbols into a templated component.
Maybe we can do the same with private and public symbols.

@AlitaBernachot AlitaBernachot merged commit 8c39a25 into main Dec 19, 2024
2 checks passed
@AlitaBernachot AlitaBernachot deleted the GSLUX-734-my-symbols branch December 19, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants