Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-767: Support for profile routing in v3 #176

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

AlitaBernachot
Copy link
Contributor

@AlitaBernachot AlitaBernachot commented Dec 1, 2024

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-767

Description

  • add new component to be used in v3 for profile support in v3 Routing
  • improve performances display of geomarker on mark (added useSpatialIndex, declutter, updateWhileAnimating, updateWhileInteracting ol props on layer anf feature)
  • add new possibility to deactivate profile through a ref passed to the composable

@AlitaBernachot AlitaBernachot changed the title GSLUX-767: Support for profile rourting in v3 GSLUX-767: Support for profile routing in v3 Dec 1, 2024
Copy link
Contributor

github-actions bot commented Dec 1, 2024

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-767-profile-routing-v3/

Copy link
Contributor

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AlitaBernachot ! Code LGTM and routing profile works well in v3 with mocked data, also updating to a new route I have the impression :-)

I guess you already added the infos profile in this PR on purpose?

@AlitaBernachot AlitaBernachot merged commit 4cf9e8b into main Dec 2, 2024
2 checks passed
@AlitaBernachot AlitaBernachot deleted the GSLUX-767-profile-routing-v3 branch December 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants