Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-668: Sidebar position is different in V3 and V4. #89

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

rmichaelis
Copy link
Collaborator

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-668

Description

The sidebar size is calculated differently in V3 and V4.

Screenshots

image

Copy link
Contributor

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-668-slider-comparator/

Copy link
Contributor

@AlitaBernachot AlitaBernachot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
I have fixed onKeyDownLeft/Right causing the CI error (errors on some e2e tests).

@AlitaBernachot AlitaBernachot changed the title Sidebar position is different in V3 and V4. GSLUX-668: Sidebar position is different in V3 and V4. Apr 11, 2024
@AlitaBernachot AlitaBernachot merged commit 0d9784a into main Apr 11, 2024
2 checks passed
@AlitaBernachot AlitaBernachot deleted the GSLUX-668-slider-comparator branch April 11, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants