Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector layers on product pages (DEA Coastlines) #368

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

benji-glitsos-ga
Copy link
Collaborator

@benji-glitsos-ga benji-glitsos-ga commented Dec 23, 2024

Copy link

github-actions bot commented Dec 23, 2024

Preview is ready!

View the preview: 🌐 PR Preview 368

You can also view the deploy log or read the documentation.

@benji-glitsos-ga
Copy link
Collaborator Author

Robbi has approved the design, including the fields of data. Robbi will populate the Coastlines data Type and Units values.

@benji-glitsos-ga benji-glitsos-ga marked this pull request as ready for review February 6, 2025 03:58
@benji-glitsos-ga benji-glitsos-ga marked this pull request as draft February 6, 2025 03:59
@benji-glitsos-ga benji-glitsos-ga marked this pull request as ready for review February 6, 2025 04:54
@benji-glitsos-ga
Copy link
Collaborator Author

@robbibt and @CEKrause -- this PR is now ready for review whenever you get a chance.

@CEKrause
Copy link
Collaborator

CEKrause commented Feb 6, 2025

I think this PR needs checking - the Coastlines page has reference to Hotspots. Possibly some copy/paste that didn't get fixed?

@benji-glitsos-ga
Copy link
Collaborator Author

@CEKrause I asked Robbi and he said 'hotspots_zoom' is a term used in DEA Coastlines that is actually unrelated to DEA Hotspots. It is used to mean 'a place of significant coastal change'

@robbibt
Copy link
Member

robbibt commented Feb 7, 2025

I think this PR needs checking - the Coastlines page has reference to Hotspots. Possibly some copy/paste that didn't get fixed?

Yep, no link to the DEA Hotspots product, the layers in Coastlines describe hotspots of extreme coastal change.

@benji-glitsos-ga benji-glitsos-ga changed the title Vector layers on product pages Vector layers on product pages (DEA Coastlines) Feb 7, 2025
Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks brilliant! One other suggested change here:

docs/data/product/dea-coastlines/_tables.yaml Outdated Show resolved Hide resolved
Co-authored-by: Robbi Bishop-Taylor <Robbi.BishopTaylor@ga.gov.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants