Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding command line interfaces and entry points #15

Merged
merged 13 commits into from
Jan 23, 2025
Merged

Conversation

caitlinadams
Copy link
Collaborator

This PR introduces major restructuring to move configuration options and hardcoded filepaths out of core functions and into configuration files which can be taken via command line arguments. The key changes are:

  • Adding a cli module and updating the pyproject.toml file to use functions from here as entry points
  • Creating cli functions that allow a user to find S1 files on NCI based on the file id, run pyrosar+GAMMA processing on a scene, or submit a scene for processing to the NCI queue
  • Removing hardcoded paths in modules, instead taking parameters that can be set on the command line or a configuration file
  • Removing unused functions after restructure

@caitlinadams caitlinadams marked this pull request as ready for review January 23, 2025 05:03
@caitlinadams
Copy link
Collaborator Author

Noting that many files still have hard-coded paths and environment variables.

The biggest issue is for running the submission cli, which calls out to sar_antarctica/nci/submission/pyrosar_gamma/submit_job.py -- this currently has a hard-coded section for starting my personal development micromamba environment. This needs to be configurable (and eventually default to the NCI module) to allow multiple developers to submit jobs with development code.

@caitlinadams caitlinadams merged commit 13bb0dc into main Jan 23, 2025
1 check passed
@caitlinadams caitlinadams deleted the cli-update branch January 23, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant