Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push to S3 #17

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Push to S3 #17

merged 5 commits into from
Jan 31, 2025

Conversation

abradley60
Copy link
Collaborator

  • Adding function to upload files in a local folder to a specified s3 bucket and folder
  • The substructure of the specified folder will be maintained
  • Adding a command line tool that can be called
  • Added the default logging level of 'info' to the cli.py script

Copy link
Collaborator

@caitlinadams caitlinadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Alex!

Before merging:

  • Can you please update the environment.yml file to include boto3 and dependencies? I needed to do pip install boto3 to get it working
  • Perhaps include an option to allow a user to upload a whole folder (e.g. my-folder/folder bucket my-s3-folder would create my-s3-folder/folder which contained the files)

Looks great and works well otherwise, so happy to approve :)

@abradley60
Copy link
Collaborator Author

abradley60 commented Jan 24, 2025

@caitlinadams the following changes have been made:

  • Added dependancies for environment
  • renamed the cli from push_folder_to_s3 -> upload_files_in_folder_to_s3 for clarity. The --upload-folder flag can be set to indicate the whole src_folder should be uploaded to the specified s3_bucket_folder, rather than just the files and subfolders inside of the src_folder.

Let me know if any other changes needed

@caitlinadams caitlinadams merged commit 3c9e03a into main Jan 31, 2025
1 check passed
@caitlinadams caitlinadams deleted the aws-upload branch January 31, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants