Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added German Localization #1998

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

patrickscheips
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

This PR includes a complete German translation. Also, the language in local account creation is now been set based on getDefaultState().user.language.

- Language in local account creation is now been set based on getDefaultState().user.language
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fa0bed) 98.19% compared to head (19749ec) 98.19%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1998   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         786      786           
  Lines       12307    12308    +1     
=======================================
+ Hits        12085    12086    +1     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Jan 5, 2024

Job #2231: Bundle Size — 9.37MiB (+2.71%).

19749ec(current) vs d179b7f master#2230(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #2231
     Baseline
Job #2230
Regression  Initial JS 5.18MiB(+5.01%) 4.93MiB
No change  Initial CSS 302.47KiB 302.47KiB
No change  Cache Invalidation 53.99% 53.99%
No change  Chunks 51 51
No change  Assets 158 158
Change  Modules 1425(+0.21%) 1422
No change  Duplicate Modules 20 20
Improvement  Duplicate Code 0.81%(-2.41%) 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #2231
     Baseline
Job #2230
Regression  JS 6.85MiB (+3.74%) 6.6MiB
Not changed  IMG 2.08MiB 2.08MiB
Not changed  CSS 318.98KiB 318.98KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.14KiB 16.14KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2231 reportView patrickscheips:master branch activity

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR! 🙏

Are you using Gladys from Germany? I'm happy to learn that we now have a user there!! 😄

Did you test this PR in real life?

@patrickscheips
Copy link
Contributor Author

patrickscheips commented Jan 5, 2024

Indeed, I'm using Gladys from Germany 😄 I really like it's end-user usability which I think is much better than other solutions.

Yes, I did test this PR in real life. It's working fine and as expected.

@Pierre-Gilles
Copy link
Contributor

Very nice, thanks for contributing :)

It's good for me to merge this, but I'm thinking about the future: how will we translate new features to german?

Right now I speak fluently both available languages (FR+EN) but German not so much (I still know a few sentences from high school but haven't speak much in the past years!!)

We could use: https://www.deepl.com/en/translator, or ChatGPT, or ask for your help if you are around

@Pierre-Gilles Pierre-Gilles merged commit 396efc7 into GladysAssistant:master Jan 5, 2024
9 checks passed
@patrickscheips
Copy link
Contributor Author

You are welcome! And thank you too!

I'm happy to translate new features into German. Deepl and ChatGPT also provide reasonable results but don't always give consistent translations. So if I can't work on German translations in time I think using Deepl/ChatGPT translations for the time being would work – or even leaving them untranslated. Then I would provide German translations as soon as possible.

@Pierre-Gilles
Copy link
Contributor

That works for me! We'll do DeepL/ChatGPT by default and if you find any inconsistencies don't hesitate we can fix them :)

By the way, don't hesitate to join us on the International forum: https://en-community.gladysassistant.com/

It's not very active for now, but usage there is growing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants