-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added German Localization #1998
Conversation
- Language in local account creation is now been set based on getDefaultState().user.language
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1998 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 786 786
Lines 12307 12308 +1
=======================================
+ Hits 12085 12086 +1
Misses 222 222 ☔ View full report in Codecov by Sentry. |
Job #2231: Bundle Size — 9.37MiB (+2.71%).
Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #2231 report View patrickscheips:master branch activity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR! 🙏
Are you using Gladys from Germany? I'm happy to learn that we now have a user there!! 😄
Did you test this PR in real life?
Indeed, I'm using Gladys from Germany 😄 I really like it's end-user usability which I think is much better than other solutions. Yes, I did test this PR in real life. It's working fine and as expected. |
Very nice, thanks for contributing :) It's good for me to merge this, but I'm thinking about the future: how will we translate new features to german? Right now I speak fluently both available languages (FR+EN) but German not so much (I still know a few sentences from high school but haven't speak much in the past years!!) We could use: https://www.deepl.com/en/translator, or ChatGPT, or ask for your help if you are around |
You are welcome! And thank you too! I'm happy to translate new features into German. Deepl and ChatGPT also provide reasonable results but don't always give consistent translations. So if I can't work on German translations in time I think using Deepl/ChatGPT translations for the time being would work – or even leaving them untranslated. Then I would provide German translations as soon as possible. |
That works for me! We'll do DeepL/ChatGPT by default and if you find any inconsistencies don't hesitate we can fix them :) By the way, don't hesitate to join us on the International forum: https://en-community.gladysassistant.com/ It's not very active for now, but usage there is growing! |
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
This PR includes a complete German translation. Also, the language in local account creation is now been set based on
getDefaultState().user.language
.