Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT : Add better validation errors on create device form #2244

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Fix #2232

Screenshot 2025-02-28 at 15 25 58

Copy link

cloudflare-workers-and-pages bot commented Feb 28, 2025

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 127d10c
Status: ✅  Deploy successful!
Preview URL: https://919f22bc.gladys-plus.pages.dev
Branch Preview URL: https://improve-validation-mqtt-devi.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (d2859f2) to head (127d10c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2244   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         878      878           
  Lines       14550    14550           
=======================================
  Hits        14341    14341           
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Feb 28, 2025

#3055 Bundle Size — 10.66MiB (+0.03%).

127d10c(current) vs d2859f2 master#3053(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#3055
     Baseline
#3053
Regression  Initial JS 5.84MiB(+0.06%) 5.84MiB
No change  Initial CSS 305.21KiB 305.21KiB
Change  Cache Invalidation 54.69% 0%
No change  Chunks 51 51
No change  Assets 172 172
No change  Modules 1583 1583
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.89% 0.89%
No change  Packages 135 135
No change  Duplicate Packages 2 2
Bundle size by type  Change 6 changes Regression 6 regressions
                 Current
#3055
     Baseline
#3053
Regression  JS 7.7MiB (+100%) undefined
Regression  IMG 2.52MiB (+100%) undefined
Regression  CSS 323.06KiB (+100%) undefined
Regression  Fonts 93.55KiB (+100%) undefined
Regression  Other 18.21KiB (+100%) undefined
Regression  HTML 13.58KiB (+100%) undefined

Bundle analysis reportBranch improve-validation-mqtt-deviceProject dashboard


Generated by RelativeCIDocumentationReport issue

@Pierre-Gilles Pierre-Gilles merged commit e1ec520 into master Feb 28, 2025
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the improve-validation-mqtt-device branch February 28, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant