Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Widget Dialog Fixes #193

Merged
merged 14 commits into from
Feb 14, 2025
Merged

Add Widget Dialog Fixes #193

merged 14 commits into from
Feb 14, 2025

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Jan 14, 2025

  • Switching tabs while dragging no longer breaks everything
  • Reorganized (and improved) add widget dialog

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 76.25899% with 33 lines in your changes missing coverage. Please review.

Project coverage is 77.10%. Comparing base (9d2e0c7) to head (6bad22e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/pages/dashboard_page.dart 81.30% 20 Missing ⚠️
lib/widgets/network_tree/networktables_tree.dart 57.89% 8 Missing ⚠️
lib/widgets/dialog_widgets/layout_drag_tile.dart 42.85% 4 Missing ⚠️
lib/widgets/tab_grid.dart 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   77.21%   77.10%   -0.11%     
==========================================
  Files          80       80              
  Lines        8709     8733      +24     
==========================================
+ Hits         6725     6734       +9     
- Misses       1984     1999      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the GUI Changes to Elastic's UI label Feb 1, 2025
@Gold872 Gold872 merged commit d63ef15 into main Feb 14, 2025
10 checks passed
@Gold872 Gold872 deleted the add-widget-fixes branch February 14, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Changes to Elastic's UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant