Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DS Height Resizing #213

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Fix DS Height Resizing #213

merged 6 commits into from
Feb 13, 2025

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Feb 3, 2025

Resolves #212

@github-actions github-actions bot added the GUI Changes to Elastic's UI label Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.01%. Comparing base (860139b) to head (93b2e48).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/pages/dashboard_page.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   76.00%   76.01%           
=======================================
  Files          80       80           
  Lines        8645     8644    -1     
=======================================
  Hits         6571     6571           
+ Misses       2074     2073    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872
Copy link
Owner Author

Gold872 commented Feb 3, 2025

@auscompgeek could you try out this build and see if it fixes it?

@auscompgeek
Copy link

I'll see if I get a chance to test this this evening

@auscompgeek
Copy link

I downloaded the portable build from commit 13120a9, still see the same size gap

@Gold872
Copy link
Owner Author

Gold872 commented Feb 7, 2025

What are the details of your screen? (Size, resolution, dpi, etc)

@auscompgeek
Copy link

13" laptop, 1080p, 125% display scaling

@Gold872
Copy link
Owner Author

Gold872 commented Feb 11, 2025

I wonder if the taskbar being visible is causing an issue, does this happen if you have the taskbar automatically hide?

@Gold872 Gold872 merged commit 6df4287 into main Feb 13, 2025
10 checks passed
@Gold872 Gold872 deleted the fix-ds-resize branch February 13, 2025 18:30
@Gold872
Copy link
Owner Author

Gold872 commented Feb 13, 2025

I know this didn't fix the issue but there were some unrelated math errors solved in this PR, I'll reopen the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Changes to Elastic's UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Driver station sizing leaves gap between dashboard and DS
2 participants