Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix robot notifications appearing off-screen #224

Merged
merged 2 commits into from
Feb 23, 2025
Merged

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Feb 21, 2025

Resolves #221

The issue is in the elegant_notification package, a PR for the fix has been opened here

Once the PR is merged I'll update the package version, but for now I'm having the dependency be downloaded from my fork of the package.

@github-actions github-actions bot added GUI Changes to Elastic's UI dependencies Changes to Elastic's dependencies labels Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.09%. Comparing base (48ff58f) to head (293a5a6).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   77.02%   77.09%   +0.07%     
==========================================
  Files          80       80              
  Lines        8737     8729       -8     
==========================================
  Hits         6730     6730              
+ Misses       2007     1999       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872 Gold872 merged commit d8771af into main Feb 23, 2025
10 checks passed
@Gold872 Gold872 deleted the fix-robot-notifications branch February 23, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to Elastic's dependencies GUI Changes to Elastic's UI
Projects
None yet
1 participant