Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port] Port Guidebook Tables From Wizden PR #28484 (#1427) #27

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

CerberusWolfie
Copy link
Contributor

@CerberusWolfie CerberusWolfie commented Jan 5, 2025

Description

This ports the Guidebook Tables to allow <Table> and <ColorBox> embeds in the Guidebook.
This just adds extra XML tags to use in rich-text.


TODO

  • Cherry-Pick the PR.
  • Tested to make sure it works. It does actively work.

Media

Guidebook Screenshot

image

NOTE: This screenshot was taken in the dev-environment. I just copy-pasted my SOP for Alert Levels to check it, since it uses both the <Table> and <ColorBox> identifiers.

# Description
This ports the Guidebook Tables to allow \<Table\> and \<ColorBox\>
embeds in the Guidebook.
This just adds extra XML tags to use in rich-text.

---

# TODO
- [x] Cherry-Pick the PR.
- [x] Tested to make sure it works. It does actively work.

---

# Media
<details><summary><h3>Guidebook Screenshot</h3></summary>
<p>

![image](https://github.com/user-attachments/assets/289e4c72-dcef-4489-b89e-5a2d6367124f)
</p>
</details>

NOTE: This screenshot was taken in the dev-environment. I just
copy-pasted my SOP for Alert Levels to check it, since it uses both the
\<Table\> and \<ColorBox\> identifiers.

---

# Changelog
:cl:
- add: Added <Table> and <ColorBox> identifiers. Go wild in SOP!

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
@CerberusWolfie
Copy link
Contributor Author

Taken from upstream.

@CerberusWolfie CerberusWolfie mentioned this pull request Jan 5, 2025
7 tasks
@Aidenkrz Aidenkrz merged commit 464813a into Goob-Station:main Jan 6, 2025
6 checks passed
@CerberusWolfie CerberusWolfie deleted the PortTables branch January 7, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants