Implement MissingOneImplementation LineChart #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleJu
force-pushed
the
chart-one-missing
branch
from
fe7d2dd to
6131aae
Compare
KyleJu
force-pushed
the
chart-one-missing
branch
from
6131aae to
0445599
Compare
KyleJu
changed the title
|
@jcscottiii Ready for a look! I will update the playwright tests in the end :) |
jcscottiii
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
LGTM.
Added a note about _fetchMissingOneImplemenationCounts and createDisplayDataFromMap
Now that we are adding more details to the page, we should probably move the charts into their own component. Similar to how I mentioned in @DanielRyanSmith's PR #944 (review). This can come after this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#838. Refactor the webstatus-gchart.ts LineChart to be used for both GlobalFeatureSupport and MissingOneImplementation charts, given the same backend data type.
Also Added TODOs for the follow-up PRs