fix: support default for BeforeUnload prompt (#2412)

https://w3c.github.io/webdriver/#dfn-get-the-prompt-handler Step 3.
GoogleChromeLabs · Jul 12, 2024 · f24ad85 · f24ad85
1 parent f87bb75
commit f24ad85
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/bidiMapper/modules/context/BrowsingContextImpl.ts b/src/bidiMapper/modules/context/BrowsingContextImpl.ts
@@ -712,6 +712,7 @@ export class BrowsingContextImpl {
       case BrowsingContext.UserPromptType.Beforeunload:
         return (
           this.#unhandledPromptBehavior?.beforeUnload ??
+          this.#unhandledPromptBehavior?.default ??
           // In WebDriver Classic spec, `beforeUnload` prompt should be accepted by
           // default. Step 4 of "Get the prompt handler" algorithm
           // (https://w3c.github.io/webdriver/#dfn-get-the-prompt-handler):

diff --git a/tests/browsing_context/test_user_prompt.py b/tests/browsing_context/test_user_prompt.py
@@ -249,6 +249,16 @@ async def test_browsingContext_beforeUnloadPromptOpened_capabilityRespected(
         if 'beforeUnload' in capabilities['unhandledPromptBehavior']:
             expected_handler = capabilities['unhandledPromptBehavior'][
                 'beforeUnload']
+        elif 'default' in capabilities['unhandledPromptBehavior']:
+            expected_handler = capabilities['unhandledPromptBehavior'][
+                'default']
+        if isinstance(capabilities['unhandledPromptBehavior'], str):
+            if capabilities[
+                    'unhandledPromptBehavior'] == 'dismiss' or capabilities[
+                        'unhandledPromptBehavior'] == 'dismiss and notify':
+                expected_handler = 'dismiss'
+            elif capabilities['unhandledPromptBehavior'] == 'ignore':
+                expected_handler = 'ignore'
 
     resp = await read_JSON_message(websocket)
     assert resp == {