chore: user prompt before the mapper tab closed #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightning00Blade
approved these changes
May 2, 2024
sadym-chromium
force-pushed
the
sadym/mapper-tab-unload
branch
from
dfb98a0 to
abc1b9b
Compare
T3-M4
pushed a commit
to bayandin/chromedriver
that referenced
this pull request
May 2, 2024
The Mapper changes are in GoogleChromeLabs/chromium-bidi#2182 and https://crrev.com/c/5509316 Bug: chromedriver:4761 Change-Id: I3e27335158482343e7187db2e1c1bb23a7c389e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5508600 Commit-Queue: Maksim Sadym <sadym@chromium.org> Reviewed-by: Vladimir Nechaev <nechaev@chromium.org> Cr-Commit-Position: refs/heads/main@{#1295379}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onbeforeunloadhandler to the mapper tab.onbeforeunloadwill be triggered.Required follow up: