Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use separate ports for QuitQuitQuit tests #748

Merged
merged 1 commit into from
Jan 15, 2025
Merged

chore: use separate ports for QuitQuitQuit tests #748

merged 1 commit into from
Jan 15, 2025

Conversation

enocom
Copy link
Member

@enocom enocom commented Jan 15, 2025

Windows test runs are failing frequently, presumably because shutting down the HTTP server and releasing the port takes longer than macOS or Linux.

This commit is a simple fix and uses separate ports to avoid collision.

Fixes #739

@enocom enocom requested a review from a team as a code owner January 15, 2025 17:43
Copy link
Collaborator

@nancynh nancynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Windows test runs are failing frequently, presumably because shutting
down the HTTP server and releasing the port takes longer than macOS or
Linux.

This commit is a simple fix and uses separate ports to avoid collision.

Fixes #739
@enocom enocom merged commit 5c1f8ff into main Jan 15, 2025
16 checks passed
@enocom enocom deleted the flaky-test branch January 15, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd: TestQuitQuitQuitGet failed
2 participants