feat: enable Proxy to be started with DNS names #2363
Merged
+56
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration test will be added as a fast follow, waiting for backend changes propagate |
hessjcg
approved these changes
Jan 29, 2025
|
Added integration test for customer CAS instance with instance connection name and domain name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default Go Connector Option
WithDNSResolverto the Cloud SQL Proxy.This Option allows the Proxy to be started with either an instance connection name or a DNS name.
The
WithDNSResolverOption configures the underlying Cloud SQL Go Connectorto first attempt to parse value as an instance connection name, if it is not a valid
instance connection name then attempt to parse as DNS name.