-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copy_tool.py #298
base: master
Are you sure you want to change the base?
Update copy_tool.py #298
Conversation
Modified the download link/URL pattern for KAFKA_LINK to point to the latest version. The previous pattern/version was broken.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@@ -17,9 +17,9 @@ | |||
import tempfile | |||
import subprocess | |||
|
|||
KAFKA_RELEASE = "2.6.0" | |||
KAFKA_RELEASE = "3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is changing a major version that has many changes, including API changes and dropped complatibility. for Java 8 - https://downloads.apache.org/kafka/3.0.0/RELEASE_NOTES.html. We havent fully tested with Kafka 3.0 and will defer this upgrade until then.
Lets revert to 2.6.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is changing a major version that has many changes, including API changes and dropped complatibility. for Java 8 - https://downloads.apache.org/kafka/3.0.0/RELEASE_NOTES.html. We havent fully tested with Kafka 3.0 and will defer this upgrade until then.
Lets revert to 2.6.0.
KAFKA_FOLDER = f"kafka_2.13-{KAFKA_RELEASE}" | ||
KAFKA_LINK = f"https://downloads.apache.org/kafka/{KAFKA_RELEASE}/{KAFKA_FOLDER}.tgz" | ||
KAFKA_LINK = f"https://dlcdn.apache.org/kafka/{KAFKA_RELEASE}/{KAFKA_FOLDER}.tgz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change the link to https://archive.apache.org/dist/kafka/2.6.0/kafka_2.13-2.6.0.tgz instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. We can change it to the archive link instead
@@ -17,9 +17,9 @@ | |||
import tempfile | |||
import subprocess | |||
|
|||
KAFKA_RELEASE = "2.6.0" | |||
KAFKA_RELEASE = "3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is changing a major version that has many changes, including API changes and dropped complatibility. for Java 8 - https://downloads.apache.org/kafka/3.0.0/RELEASE_NOTES.html. We havent fully tested with Kafka 3.0 and will defer this upgrade until then.
Lets revert to 2.6.0.
Modified the download link/URL pattern for KAFKA_LINK to point to the latest version. The previous pattern/version was broken.