Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy_tool.py #298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hicod3r
Copy link

@hicod3r hicod3r commented Oct 15, 2021

Modified the download link/URL pattern for KAFKA_LINK to point to the latest version. The previous pattern/version was broken.

Modified the download link/URL pattern for KAFKA_LINK to point to the latest version. The previous pattern/version was broken.
@google-cla
Copy link

google-cla bot commented Oct 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@@ -17,9 +17,9 @@
import tempfile
import subprocess

KAFKA_RELEASE = "2.6.0"
KAFKA_RELEASE = "3.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changing a major version that has many changes, including API changes and dropped complatibility. for Java 8 - https://downloads.apache.org/kafka/3.0.0/RELEASE_NOTES.html. We havent fully tested with Kafka 3.0 and will defer this upgrade until then.

Lets revert to 2.6.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changing a major version that has many changes, including API changes and dropped complatibility. for Java 8 - https://downloads.apache.org/kafka/3.0.0/RELEASE_NOTES.html. We havent fully tested with Kafka 3.0 and will defer this upgrade until then.

Lets revert to 2.6.0.

KAFKA_FOLDER = f"kafka_2.13-{KAFKA_RELEASE}"
KAFKA_LINK = f"https://downloads.apache.org/kafka/{KAFKA_RELEASE}/{KAFKA_FOLDER}.tgz"
KAFKA_LINK = f"https://dlcdn.apache.org/kafka/{KAFKA_RELEASE}/{KAFKA_FOLDER}.tgz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. We can change it to the archive link instead

@@ -17,9 +17,9 @@
import tempfile
import subprocess

KAFKA_RELEASE = "2.6.0"
KAFKA_RELEASE = "3.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changing a major version that has many changes, including API changes and dropped complatibility. for Java 8 - https://downloads.apache.org/kafka/3.0.0/RELEASE_NOTES.html. We havent fully tested with Kafka 3.0 and will defer this upgrade until then.

Lets revert to 2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants