PubSubSinkTask.flush should flush tracking for all input partitions and only those partitions #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd only those partitions
jordanbull
commented
Dec 27, 2021
| ApiFuture<String> badFuture = getFailedPublishFuture(); | ||
| when(publisher.publish(any(PubsubMessage.class))).thenReturn(badFuture); | ||
| task.put(records); | ||
| assertThrows(RuntimeException.class, () -> task.flush(partitionOffsets)); |
There was a problem hiding this comment.
Use assertThrows instead of expected so the following verifies are actually reached.
kafka-connector/src/main/java/com/google/pubsub/kafka/sink/CloudPubSubSinkTask.java
Outdated
Show resolved
Hide resolved
kafka-connector/src/main/java/com/google/pubsub/kafka/sink/CloudPubSubSinkTask.java
Show resolved
Hide resolved
fix typo
samarthsingal
approved these changes
Dec 28, 2021
Removal of partition map from allOutstandingFutures was not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing behavior will only clear tracking for the first partition that throws an exception in flush. In cases where the partitions complete successfully, it will also clear tracking for partitions that it was not asked to flush. Both of these are not the expected behavior when implementing the interface. This pull requests fixes these two behaviors and adds tests that catch them in the old code and pass with the changes.