Fix Filter Popup Panels deleting cached panel #2718
Merged
+60
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not delete cached panel for filter popups
make fields not final and set in builder methods
ghzdude
added
type: bug
kumquat-ir
requested changes
Feb 9, 2025
kumquat-ir
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fixes #2716
prevents filter popups from deleting their cached panel
also improves popup panel a bit
Implementation Details
cached panel is deleted when the panel is closed instead of only in the button
the class is now public and replaced constructor parameters with builder methods
constructor is private
popup panel methods now return the popup panel class
Outcome
filter popups can now be closed