Log alias attempts with incorrect secret (#6)

HDegroote · Jul 18, 2024 · 59415a4 · 59415a4
1 parent 39b461d
commit 59415a4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/lib/alias-rpc.js b/lib/alias-rpc.js
@@ -32,7 +32,7 @@ class AliasRpcServer extends ReadyResource {
     await this.swarm.destroy()
   }
 
-  _onconnection (socket) {
+  _onconnection (socket, info) {
     const uid = crypto.randomUUID()
     const remotePublicKey = socket.remotePublicKey
 
@@ -45,13 +45,14 @@ class AliasRpcServer extends ReadyResource {
       'alias',
       { responseEncoding: AliasRespEnc, requestEncoding: AliasReqEnc },
       async (req) => {
+        const targetPublicKey = req.targetPublicKey
+        const alias = req.alias
+
         if (!b4a.equals(req.secret, this.secret)) {
+          this.emit('alias-unauthorised', { uid, remotePublicKey, targetPublicKey, alias })
           return { success: false, errorMessage: 'unauthorised' }
         }
 
-        const targetPublicKey = req.targetPublicKey
-        const alias = req.alias
-
         this.emit('alias-request', { uid, remotePublicKey, targetPublicKey, alias })
         try {
           const updated = await this._putAlias(alias, targetPublicKey)

diff --git a/run.js b/run.js
@@ -115,6 +115,13 @@ function setupLogging (bridge, logger) {
     }
   )
 
+  // TODO: log IP address + rate limit
+  bridge.aliasRpcServer.on(
+    'alias-unauthorised', ({ uid, remotePublicKey, targetPublicKey, alias }) => {
+      logger.info(`Unauthorised alias request from ${idEnc.normalize(remotePublicKey)} to set alias ${alias}->${idEnc.normalize(targetPublicKey)} (uid: ${uid})`)
+    }
+  )
+
   bridge.aliasRpcServer.on(
     'register-error', ({ uid, error }) => {
       logger.info(`Alias error: ${error} (${uid})`)