html-css/week1/anita #13
Conversation
| <img src="image/profile.png" class="profile-img"> | ||
| <div class="blue-box"></div> | ||
|
|
||
| <h2 class="name"Ngah<span>Anita</span></h2> |
There was a problem hiding this comment.
I think you might have forgotten a closing bracket on the <h2>
| <h2 class="name"Ngah<span>Anita</span></h2> | |
| <h1 class="name">Ngah <span>Anita</span></h1> | |
Also, it's recommended to start the page with the biggest H tag, which would be <h1>. You can read more about the order of the headlines here - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements#usage_notes
| <div class="resume-box"> | ||
| <div class="left-section"> | ||
| <div class="profile"> | ||
| <img src="image/profile.png" class="profile-img"> |
There was a problem hiding this comment.
It's a good practice to add alt attribute to images and describe in them what is the image visualizing. This helps people using screen readers to "see" graphic elements.
| <h2 class="name"Ngah<span>Anita</span></h2> | ||
| </div> | ||
|
|
||
| <p class="n-p">Graphic & Web Designer</span><h2></h2> |
There was a problem hiding this comment.
It seems like you have a unnecessary closed </span> tag and a <h2></h2>
| <span class="icon"><i class="fa fa-map-marker" aria-hidden="true"></i></span> | ||
| <span class="text">French, English ,Danish</span> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| </div> | ||
| <div class="right_Side"></div> | ||
| </div> | ||
| </body> | ||
| </html> | ||
|
|
||
| <p1{ |
There was a problem hiding this comment.
Hmmm, there is something strange going on here. You have an extra closing </body> and </html>, and further down CSS, which is not wrapped in <style> tags.
| <h3 class="title">Contact Info</h3> | ||
| <ul> | ||
| <li> | ||
| <h5>2005 -2008</h5> | ||
| <h4>Bachelor Degree in Economics</h4> | ||
| <h4>University Name</h4> |
There was a problem hiding this comment.
The headlines order jumps a bit here. First you have h3, then you jump to h5 and then to h4. The best would be if it would be something like h3, h4, h5, h5
| <li> | ||
| <div class="right-heading"> | ||
| <img src="image/user.png"> | ||
| <p class="p2"profile></p> |
There was a problem hiding this comment.
I think this might have to be like this
<p class="p2">profile</p>
No description provided.