Week 1 Git Homework Submission - Suman #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Y. Vasilev <52400967+jason-vasilev@users.noreply.github.com>
Co-authored-by: Y. Vasilev <52400967+jason-vasilev@users.noreply.github.com>
jason-vasilev
suggested changes
Feb 1, 2025
There was a problem hiding this comment.
Hi Suman.
You still have some complex tag selectors as nav ul li a that could be replaced with class names. At another place, you've added the .primary-button class to a <button> but you never set the class in your CSS file. Please, have another go at it, if you find the time. Then you can also delete the comments like <!--Removed <hr class="order_line"> as per Yasen's suggestion -->.
PS. remember to open PRs towards your own repository instead of the HackYourFuture one, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Week 1 Git Homework Submission - Suman