Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Skip Enemy Cutscenes #1038

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Eblo
Copy link
Contributor

@Eblo Eblo commented Mar 3, 2025

Some boss cutscene skips existed, but this expands the scope to include most bosses and mini-bosses in the game.

  • Add new VB, VB_ENEMY_CUTSCENE_ACTION, that exists to be used within actor files. In most cases, it is a simple set to false to skip vanilla behavior. Other uses involve setting state information as part of the phase change cutscene skip, or a death cutscene skip. These uses were not covered by the existing cutscene hooks; some actors use their own timers and camera control for instance.
  • Renamed boss skips to enemy skips, since the scope increased over what was there before
  • Separated from story cutscene skips into new setting specifically for enemy cutscene skips

Build Artifacts

Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a little spam of comments lol, mainly trying to think about how to minimize impact to vanilla src (even if just whitesapcing related)

@Eblo
Copy link
Contributor Author

Eblo commented Mar 3, 2025

Applied the 8 early return suggestions. The diff is a little cleaner now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants