Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when interpolation enabled on linux #27

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

briaguya-ai
Copy link
Contributor

@briaguya-ai briaguya-ai commented Dec 17, 2024

i'm not sure exactly what was going on, but we were getting bad pointers in a bunch of sys_matrix functions when transitioning between screens

all of those functions had gInterpolationMatrix passed in when they were called, and that should be set in

gInterpolationMatrix = &sInterpolationMatrixStack[0];

so my guess is that we were sometimes getting to those functions before it was being set? (on scene transition of some sort?)

i wish i had a better understanding of why we were getting bad pointers, but doing this makes it so we don't get bad pointers and the game doesn't crash (and it's a tiny 1 line fix that seems reasonable so 🤷 i guess?)

@KiritoDv KiritoDv merged commit ea87066 into HarbourMasters:main Dec 21, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants