Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport subpackages #116

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Reexport subpackages #116

merged 6 commits into from
Jan 23, 2025

Conversation

ReubenJ
Copy link
Member

@ReubenJ ReubenJ commented Nov 14, 2024

When using Herb, we usually have to add using HerbGrammar, HerbSearch, etc., meaning we don't get any benefit from using Herb in the first place. This change allows you to access anything exported from HerbGrammar, HerbSearch, etc., after only using Herb.

Before, this failed:

using Herb
# needs using HerbGrammar

# or HerbGrammar.@cfgrammar
g = @cfgrammar begin
    a = 1
end

With this change, it works without the extra using or extra HerbGrammar. before the macro call.

@ReubenJ ReubenJ self-assigned this Nov 14, 2024
@ReubenJ ReubenJ added the enhancement New feature or request label Nov 14, 2024
@ReubenJ ReubenJ marked this pull request as draft November 26, 2024 10:39
@ReubenJ

This comment was marked as resolved.

@ReubenJ

This comment was marked as resolved.

@ReubenJ ReubenJ force-pushed the feat/reexport-subpackages branch 4 times, most recently from f7dde3a to da8fb7c Compare January 22, 2025 20:48
As this just opens up the subpackages' APIs, it is not a
breaking change.
The caret is the default SemVer behavior (https://pkgdocs.julialang.org/v1/compatibility/\#Caret-specifiers)
and it seems other projects leave it off.
@ReubenJ ReubenJ force-pushed the feat/reexport-subpackages branch from da8fb7c to a4b4c4f Compare January 22, 2025 20:48
@ReubenJ ReubenJ marked this pull request as ready for review January 23, 2025 09:36
@ReubenJ ReubenJ requested a review from pwochner January 23, 2025 09:39
@ReubenJ ReubenJ force-pushed the feat/reexport-subpackages branch from a4b4c4f to ce78733 Compare January 23, 2025 09:48
Copy link
Contributor

@pwochner pwochner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, this will make using Herb so much less confusing.

@ReubenJ ReubenJ merged commit a2b2a2b into master Jan 23, 2025
3 of 4 checks passed
@ReubenJ ReubenJ deleted the feat/reexport-subpackages branch February 24, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants