Bug/csgrammar macro returns object not expr #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
@csgrammar
macro calledexpr2csgrammar(...)
at macro expansion time instead of returning an expression that included a call toexpr2csgrammar(...)
. This made it impossible for debuggers to stop on breakpoints inside calls to the macro because those breakpoints were being hit at macro expansion time, not runtime.The functionality is unchanged, but the debugging experience is improved, and the macro now follows a more Julian pattern for macros: simply taking an expression and returning an expression.