Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/csgrammar macro returns object not expr #75

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

ReubenJ
Copy link
Member

@ReubenJ ReubenJ commented May 17, 2024

Previously, the @csgrammar macro called expr2csgrammar(...) at macro expansion time instead of returning an expression that included a call to expr2csgrammar(...). This made it impossible for debuggers to stop on breakpoints inside calls to the macro because those breakpoints were being hit at macro expansion time, not runtime.

The functionality is unchanged, but the debugging experience is improved, and the macro now follows a more Julian pattern for macros: simply taking an expression and returning an expression.

@ReubenJ ReubenJ requested a review from sebdumancic May 17, 2024 14:43
@ReubenJ ReubenJ self-assigned this May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.10%. Comparing base (aca61f9) to head (04c2f4e).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #75   +/-   ##
=======================================
  Coverage   46.10%   46.10%           
=======================================
  Files           8        8           
  Lines         462      462           
=======================================
  Hits          213      213           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReubenJ ReubenJ merged commit ac6e12a into dev Jul 12, 2024
5 checks passed
@ReubenJ ReubenJ deleted the bug/csgrammar-macro-returns-object-not-expr branch July 12, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants