-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MLFSIterator, add tests for it #138
base: master
Are you sure you want to change the base?
Conversation
c992b07
to
0a6a044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch on the top-down iterator! Once we update the docstring, I think these changes are looking good 👍
Is this slower as a result of this PR? |
The previous was written before Bart, and thus didn't account for uniform trees, and is thus wrong. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 72.94% 73.95% +1.01%
==========================================
Files 19 19
Lines 669 672 +3
==========================================
+ Hits 488 497 +9
+ Misses 181 175 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also:
MLFSIterator
requires Herb-AI/HerbGrammar.jl#104 to work.