ci: fix broken ci #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiroIshida
force-pushed
the
fix_ci
branch
3 times, most recently
from
0e5d3bf to
04ad0e5
Compare
mqcmd196
pushed a commit
to mqcmd196/detic_ros
that referenced
this pull request
Feb 5, 2025
* chore: fix mypi.ini and format * docker: add option to keep launch file * ci: dont remove launch file from image in ci * ci: fix github yaml indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For actual usage, we must remove launch file directory in the image when building time to avoid name conflict when lanuching. But for the rostest inside CI, we require these launch file for testing. So I added docker ARG to ON/OFF the keeping launch file behavior. default is false, thus removed but is set to true for testing (set in github action)