Misc cleanups to PathGroupoids, Equiv, HProp and BoundedSearch #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
reviewed
Jan 15, 2025
| @@ -16,7 +16,7 @@ Local Open Scope path_scope. | |||
|
|
|||
| Theorems about concatenation of paths are called [concat_XXX] where [XXX] tells us what is on the left-hand side of the equation. You have to guess the right-hand side. We use the following symbols in [XXX]: | |||
|
|
|||
| - [1] means the identity path | |||
| - [1] means the identity path, or sometimes the identity function | |||
There was a problem hiding this comment.
Where does it mean the identity function? Typically we write id or idmap in those cases.
There was a problem hiding this comment.
`concat_A1p' and some others. Should we rename them?
Alizter
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits are independent and self-explanatory.