-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WINDOW_MANAGER] Adds display server protocol to entry #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean 🎉! LGTM, possibly a bit more detail for the changelog if you agree?
ac2abc2
to
ec479f1
Compare
So I've checked how UI layering works and it appears showing DSP info in DE entry would be more consistent. Tell me what you think about it @Tobilike @ingrinder 🙏 |
ec479f1
to
4bf0125
Compare
Hmmm, how come? As far as I know you can run independent window managers without a "DE" as such in X and Wayland (e.g. |
I tested it on Hyprland and xmonad. It is displayed in the correct place. As long as it is displayed in windows manager. Everything is fine. Very nice work by the way. It's much better integrated. |
Co-Authored-By: Tobilike <80016610+Tobilike@users.noreply.github.com>
4bf0125
to
b7323a4
Compare
Thanks for your feedbacks (I am not an expert in UI environments at all). I've reverted to first proposal (including your CHANGELOG suggestion Michael). Bye 👋 |
See #142.
How has this been tested ?
Unit tests and locally (Debian 11).
Types of changes :
Checklist :