Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENTRIES] Implements hide_undetected option to mask missing values #166

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

HorlogeSkynet
Copy link
Owner

Description

This patch adds a new configuration option to allow hiding "undetected entries".

Reason and / or context

This was wandering in my head for a while now. I guess minimal systems users (with a lot of empty values) may love this option (as this would allow them not to manually adapt entries object to remove unnecessary items).

How has this been tested ?

Unit tests + locally.

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

(partially breaking from an API point of view as __bool__ magic method Entry definition cause objects to behave differently in boolean contexts/operations)

Checklist :

  • [IF NEEDED] I have updated the README.md file accordingly ;
  • [IF NEEDED] I have updated the test cases (which pass) accordingly ;
  • [IF BREAKING] This pull request targets next Archey version branch ;
  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (PEP8).

@HorlogeSkynet HorlogeSkynet added the enhancement ⬆️ Implements a new feature, fixes or improves existing ones label Mar 1, 2025
@HorlogeSkynet HorlogeSkynet requested a review from ingrinder March 1, 2025 21:27
@HorlogeSkynet HorlogeSkynet self-assigned this Mar 1, 2025
Copy link
Collaborator

@ingrinder ingrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea, and LGTM!

(partially breaking from an API point of view as __bool__ magic method Entry definition cause objects to behave differently in boolean contexts/operations)

This seems like the more "correct" behaviour anyway 👍

@HorlogeSkynet HorlogeSkynet force-pushed the feat/hide_undetected_entry branch from aecb1de to 20bf632 Compare March 2, 2025 09:10
@HorlogeSkynet
Copy link
Owner Author

Changelog and Entry unit tests updated according to __bool__ changes; Merging here, thanks ! 🙏

@HorlogeSkynet HorlogeSkynet merged commit ef6c91f into master Mar 2, 2025
30 checks passed
@HorlogeSkynet HorlogeSkynet deleted the feat/hide_undetected_entry branch March 2, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

2 participants