-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix newick output #73
Conversation
Reviewer's Guide by SourceryThis PR fixes issues with Newick tree output formatting by modifying the tree string representation and adding error handling. The changes also include some code cleanup by removing unnecessary blank lines. Sequence diagram for ctree function error handlingsequenceDiagram
participant User
participant CLI as ctree CLI
participant App as Application
participant Util as dvs_util
participant Sys as System
User->>CLI: Run ctree command
CLI->>App: Call app(seqs)
alt Tree is None
App-->>CLI: Return None
CLI->>Util: Print error message
CLI->>Sys: Exit with error
else Tree is valid
App-->>CLI: Return Tree
CLI->>User: Write tree to outpath
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GavinHuttley - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Pull Request Test Coverage Report for Build 11715161343Details
💛 - Coveralls |
Summary by Sourcery
Fix the Newick output formatting by removing quotes from the string representation of the tree dictionary. Enhance the 'ctree' function to handle cases where the tree is not generated by printing an error message and exiting. Update the test for 'ctree' to include the '-hp' flag in the arguments.
Bug Fixes:
Enhancements:
Tests: