Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main #96

Merged
merged 21 commits into from
Jan 12, 2025
Merged

Merge main #96

merged 21 commits into from
Jan 12, 2025

Conversation

GavinHuttley
Copy link
Collaborator

@GavinHuttley GavinHuttley commented Jan 12, 2025

Summary by Sourcery

Update BRCA1 test data and improve sequence selection stability.

Enhancements:

  • Preserve input sequence collection type when selecting sequences.

CI:

  • Update CI to use latest version of uv.

Tests:

  • Add tests for serialisability and return type consistency in sequence selection.

GavinHuttley and others added 21 commits November 22, 2024 19:12
Mods for composable app usability
Bumps [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) from 3 to 4.
- [Release notes](https://github.com/astral-sh/setup-uv/releases)
- [Commits](astral-sh/setup-uv@v3...v4)

---
updated-dependencies:
- dependency-name: astral-sh/setup-uv
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.7.3 to 0.8.1.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.7.3...0.8.1)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…al-sh/setup-uv-4

Bump astral-sh/setup-uv from 3 to 4
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.8.1 to 0.8.2.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.8.1...0.8.2)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.8.2 to 0.8.3.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.8.2...0.8.3)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) from 4 to 5.
- [Release notes](https://github.com/astral-sh/setup-uv/releases)
- [Commits](astral-sh/setup-uv@v4...v5)

---
updated-dependencies:
- dependency-name: astral-sh/setup-uv
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.8.3 to 0.8.4.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.8.3...0.8.4)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
DEV: address rename of piqtree2 to piqtree
…al-sh/setup-uv-5

Bump astral-sh/setup-uv from 4 to 5
REL: bumped version to 2024.12.26a1
Copy link

sourcery-ai bot commented Jan 12, 2025

Reviewer's Guide by Sourcery

This pull request updates the paper.bib file by adding DOIs and other metadata to existing entries, and adds several new article citations. It also modifies tests/test_records.py to include new tests for serializability and return types, and updates src/diverse_seq/records.py to improve type hinting and ensure consistent return types. Finally, it updates package metadata, including version and dependencies.

Class diagram showing updated type hints in records.py

classDiagram
    class AppOutType {
        <<Union>>
        SeqsCollectionType
        SerialisableType
    }

    class DiverseSeqBase {
        +__init__(moltype, k, seed, include)
        +main(seqs: SeqsCollectionType) AppOutType
    }

    note for AppOutType "New type alias for improved
return type specification"

    note for DiverseSeqBase "Updated return type
to be more flexible"
Loading

File-Level Changes

Change Details Files
Updated paper.bib with DOIs and metadata
  • Added DOIs and URLs to existing entries.
  • Added metadata such as language, editor, and issue number.
  • Standardized formatting of entries.
paper/paper.bib
Added new citations to paper.bib
  • Added citations for relevant articles.
  • Ensured new entries conform to the existing formatting standards.
paper/paper.bib
Improved tests for sequence records
  • Added tests for serializability of nmost and max functions.
  • Added tests to check return types of select functions.
  • Parameterized tests to cover different cases.
tests/test_records.py
Improved type hinting and return types
  • Added AppOutType to handle union of sequence collection and serializable types.
  • Updated main functions to return consistent types.
  • Improved documentation for return types.
src/diverse_seq/records.py
Updated package metadata
  • Updated package version.
  • Updated dependencies, including ruff and piqtree.
  • Updated CI workflow to use latest setup-uv action.
pyproject.toml
__init__.py
.github/workflows/ci-cogent3-dev.yml
Added aligned BRCA1 sequences for testing
  • Added aligned sequences to the brca1.fasta file.
  • This provides a consistent dataset for testing alignment-related functions.
tests/data/brca1.fasta

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GavinHuttley - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12737805197

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 91.898%

Totals Coverage Status
Change from base Build 11785964138: 0.006%
Covered Lines: 1191
Relevant Lines: 1296

💛 - Coveralls

@GavinHuttley GavinHuttley merged commit 20a8e8e into JOSS Jan 12, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants