tese

IABTechLab · Jan 18, 2025 · aa91898 · aa91898
1 parent 8975de3
commit aa91898
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/scripts/gcp-oidc/gcp.py b/scripts/gcp-oidc/gcp.py
@@ -42,10 +42,11 @@ def _get_secret(self, secret_identifier=None) -> ConfidentialComputeConfig:
         except NotFound:
             raise ConfigNotFound(self.__class__.__name__, f"Secret Manager {os.getenv("API_TOKEN_SECRET_NAME")}")
         config["api_token"] = secret_value
-        os.environ["gcp_secret_version_name"] = os.getenv("API_TOKEN_SECRET_NAME") # ideally add to config? 
+        os.environ["gcp_secret_version_name"] = os.getenv("API_TOKEN_SECRET_NAME") # ideally add to config?
         return config
 
     def __populate_operator_config(self, destination):
+        #Add gcp_secret_version_name here?
         target_config = f"/app/conf/uid2-config.json"
         shutil.copy(target_config, destination)
         with open(destination, 'r') as file:
@@ -69,7 +70,6 @@ def run_compute(self) -> None:
         if not self.configs.get("skip_validations"):
             self.validate_configuration()
         config_locaton = "/tmp/final-config.json"
-        gcp_secret_version_name
         self.__populate_operator_config(config_locaton)
         java_command = [
             "java",