Create uid2 client side secure signals page #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleysmithTTD
commented
Jan 31, 2025
| context: examples/google-secure-signals-integration/client_side | ||
| push: true | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} |
There was a problem hiding this comment.
Do we still want to couple all of these between a release file for each and then a publish file for all three together? Or do we want to make each one a separate publish yml file? This can be done now or later.
Also side note: we should probably rename the "standard" secure signals site to client-server which we can clean up later also
There was a problem hiding this comment.
As much as it seems wasteful to have three separate files, I think it makes sense to do that. We won't always be (rarely be?) modifying all of them at once so creating new versions/images with no changes seems bad. what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.