Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UID2-2674 Add new workflow to release docker image #35

Merged

Conversation

cYKatherine
Copy link
Contributor

@cYKatherine cYKatherine commented Jan 22, 2024

@cYKatherine cYKatherine self-assigned this Jan 22, 2024
@cYKatherine cYKatherine force-pushed the kcc-UID2-2674-implement-shared-publish-to-docker-versioned branch from bce841a to 833a41c Compare January 22, 2024 04:24
@cYKatherine cYKatherine force-pushed the kcc-UID2-2674-implement-shared-publish-to-docker-versioned branch from c3d2724 to 3ba0ddb Compare January 22, 2024 05:41
@cYKatherine cYKatherine force-pushed the kcc-UID2-2674-implement-shared-publish-to-docker-versioned branch from eb581ee to ad242ef Compare January 22, 2024 05:46
@cYKatherine cYKatherine force-pushed the kcc-UID2-2674-implement-shared-publish-to-docker-versioned branch 2 times, most recently from b69dacf to 6df29ab Compare January 22, 2024 06:06
@cYKatherine cYKatherine force-pushed the kcc-UID2-2674-implement-shared-publish-to-docker-versioned branch 5 times, most recently from c847f8f to ee899c4 Compare January 22, 2024 07:55
@cYKatherine cYKatherine force-pushed the kcc-UID2-2674-implement-shared-publish-to-docker-versioned branch 2 times, most recently from 1142932 to e649d7b Compare January 22, 2024 08:01
inputs:
release_type:
type: choice
description: 'The type of release'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for quotes

Also, does this need required: true?

inputs:
release_type:
type: choice
description: 'The type of release'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here about quotes and required: true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's a type: choice, I don't think we need to add required: true as it's a dropdown menu

@cYKatherine cYKatherine merged commit 614b711 into main Jan 24, 2024
2 checks passed
@cYKatherine cYKatherine deleted the kcc-UID2-2674-implement-shared-publish-to-docker-versioned branch January 24, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants