abu-add-kms-usage-explicit #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genwhittTTD
reviewed
Jan 29, 2025
genwhittTTD
reviewed
Jan 31, 2025
| | `SSMKeyAlias` | `AWS::KMS::Alias` | An alias that provides an easy way to access the [KMS](https://aws.amazon.com/kms/) key. | | ||
| | `TokenSecret` | `AWS::SecretsManager::Secret` | An encrypted configuration that includes the operator key. | | ||
| | `WorkerRole` | `AWS::IAM::Role` | The IAM role that your UID2 Operators run as. Roles provide access to configuration keys. | | ||
| | `TokenSecret` | `AWS::SecretsManager::Secret` | Secret manager to store the operator key. | |
There was a problem hiding this comment.
Secret manager to store the operator key.
Not sure about this now. Is it the location? The name? Adjust as needed. Suggest:
Location of the AWS Secret Manager for storing the operator key.
There was a problem hiding this comment.
It is not the location,
What about ; "A Secrets Manager secret to store the operator key. " ?
genwhittTTD
approved these changes
Jan 31, 2025
| | `TokenSecret` | `AWS::SecretsManager::Secret` | An encrypted configuration that includes the operator key. | | ||
| | `WorkerRole` | `AWS::IAM::Role` | The IAM role that your UID2 Operators run as. Roles provide access to configuration keys. | | ||
| | `TokenSecret` | `AWS::SecretsManager::Secret` | A Secrets Manager secret to store the operator key. | | ||
| | `WorkerRole` | `AWS::IAM::Role` | The IAM role that your UID2 Operators run as. Role provide access to AWS Secrets Manager to retrieve operator keys. | |
There was a problem hiding this comment.
Role provide access to AWS Secrets Manager to retrieve operator keys.
Suggest
The role provides access...
or
Roles provide access...
probably the first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.